Component notifications can be silenced #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrooksuk
force-pushed
the
silent-component-changes
branch
from
8020817
to
f3ccd6d
Compare
|
@jbrooksuk Looks ok! This will silent all notifications for a component right? But what happens if I just don't want to notify users a single time and then they can keep getting updates? |
|
This is just per-update. If you silence once, the next time it won't be unless you specify again. Or am I misunderstanding? |
|
Lol true, my bad 😉 |
jbrooksuk
force-pushed
the
silent-component-changes
branch
from
f3ccd6d
to
8725ab2
Compare
[ci skip] [skip ci]
|
Merging this tonight 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2316
You can now supply
silentas a boolean parameter. Iftruethen we won't notify about component status changes.